From 3f281a9e5ed725050e4f7ae05d740fb78ea42a72 Mon Sep 17 00:00:00 2001
From: Arpit Chakladar <arpitchakladar+git@gmail.com>
Date: Thu, 13 Aug 2026 21:21:02 +0530
Subject: refactor: using python scripts for preparing extensions for chromium

---
 .../chromium/extensions/inject_extension_key.py    | 26 +++++++++++++++++
 modules/web/chromium/extensions/lib.nix            | 33 ++++------------------
 2 files changed, 32 insertions(+), 27 deletions(-)
 create mode 100644 modules/web/chromium/extensions/inject_extension_key.py

(limited to 'modules/web/chromium/extensions')

diff --git a/modules/web/chromium/extensions/inject_extension_key.py b/modules/web/chromium/extensions/inject_extension_key.py
new file mode 100644
index 0000000..f1b7055
--- /dev/null
+++ b/modules/web/chromium/extensions/inject_extension_key.py
@@ -0,0 +1,26 @@
+#!/usr/bin/env python3
+import json
+import re
+import sys
+
+manifest_path = sys.argv[1]
+ext_key = sys.argv[2]
+
+with open(manifest_path, "r", encoding="utf-8", errors="ignore") as f:
+    content = f.read()
+
+pattern = r"(\"[^\"]*?\")|//.*?$|/\*.*?\*/"
+clean = re.sub(
+    pattern,
+    lambda m: m.group(1) if m.group(1) else "",
+    content,
+    flags=re.DOTALL | re.MULTILINE,
+)
+
+clean = re.sub(r",\s*([\]}])", r"\1", clean)
+
+data = json.loads(clean)
+data["key"] = ext_key
+
+with open(manifest_path, "w", encoding="utf-8") as f:
+    json.dump(data, f, indent=2)
diff --git a/modules/web/chromium/extensions/lib.nix b/modules/web/chromium/extensions/lib.nix
index 1197868..fed6846 100644
--- a/modules/web/chromium/extensions/lib.nix
+++ b/modules/web/chromium/extensions/lib.nix
@@ -201,33 +201,12 @@ rec {
 
         # Inject the public key into manifest.json if provided
         ${lib.optionalString (extensionKey != null) ''
-                    if [ -f "$out/manifest.json" ]; then
-                      echo "Injecting extension key into manifest.json to lock the extension ID..."
-                      python3 -c '
-          import json, sys, re
-
-          manifest_path = sys.argv[1]
-          ext_key = sys.argv[2]
-
-          with open(manifest_path, "r", encoding="utf-8", errors="ignore") as f:
-              content = f.read()
-
-          # 1. Strip JS comments without corrupting URLs inside strings
-          pattern = r"(\"[^\"]*?\")|//.*?$|/\*.*?\*/"
-          clean = re.sub(pattern, lambda m: m.group(1) if m.group(1) else "", content, flags=re.DOTALL | re.MULTILINE)
-
-          # 2. Strip trailing commas in JSON objects/arrays
-          clean = re.sub(r",\s*([\]}])", r"\1", clean)
-
-          data = json.loads(clean)
-          data["key"] = ext_key
-
-          with open(manifest_path, "w", encoding="utf-8") as f:
-              json.dump(data, f, indent=2)
-          ' "$out/manifest.json" "${extensionKey}"
-                    else
-                      echo "Warning: No manifest.json found in $out to inject the key!" >&2
-                    fi
+          if [ -f "$out/manifest.json" ]; then
+            echo "Injecting extension key into manifest.json to lock the extension ID..."
+            python3 ${./inject_extension_key.py} "$out/manifest.json" "${extensionKey}"
+          else
+            echo "Warning: No manifest.json found in $out to inject the key!" >&2
+          fi
         ''}
 
         runHook postBuild
-- 
cgit v1.2.3