From d178caee5c93ad9ed91dbd082b0f0b5a9b0507aa Mon Sep 17 00:00:00 2001 From: Arpit Chakladar <54011232+arpitchakladar@users.noreply.github.com> Date: Mon, 27 Mar 2023 21:38:43 +0530 Subject: Refactoring code. Only using hashes for output file names. Using singleton pattern to store the callbacks for observeDOM, and only one MutationObserver. --- src/shared/modify-dom.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'src/shared/modify-dom.ts') diff --git a/src/shared/modify-dom.ts b/src/shared/modify-dom.ts index b3baffb..337c879 100644 --- a/src/shared/modify-dom.ts +++ b/src/shared/modify-dom.ts @@ -14,12 +14,16 @@ export const modifyDOM = (modificationRules: (DOMModificaitonRule | null)[]) => for (let i = 0; i < modificationRules.length; i++) { if (modificationRules[i]) { const element = document.querySelector(modificationRules[i]![0]) as HTMLElement | null; + if (element) { - const attributes = modificationRules[i]![1] as DOMReplacements; + const attributes = modificationRules[i]![1]; + if (attributes.innerHTML) { element.innerHTML = attributes.innerHTML as string; } + delete attributes.innerHTML; + for (const attribute in attributes) { if (attributes[attribute] === null) { element.removeAttribute(attribute); @@ -27,8 +31,10 @@ export const modifyDOM = (modificationRules: (DOMModificaitonRule | null)[]) => element.setAttribute(attribute, attributes[attribute] as string); } } + modificationRules[i] = null; count++; + if (count >= modificationRules.length) { return true; } -- cgit v1.2.3