From dfba7ff6fff7bde33b40a343a2318b35c429b40f Mon Sep 17 00:00:00 2001 From: Arpit Chakladar Date: Mon, 13 Jul 2026 23:28:46 +0530 Subject: refactor: fixed all of the eslint warnings and errors --- config/webpack/loader/arrange-shared-module-loader.js | 6 +++++- .../plugins/create-injected-shared-modules-webpack-plugin.js | 1 + config/webpack/plugins/create-manifest-webpack-plugin/index.js | 1 + config/webpack/plugins/create-rules-webpack-plugin.js | 1 + config/webpack/plugins/inject-script-webpack-plugin.js | 7 +++++-- 5 files changed, 13 insertions(+), 3 deletions(-) (limited to 'config/webpack') diff --git a/config/webpack/loader/arrange-shared-module-loader.js b/config/webpack/loader/arrange-shared-module-loader.js index 31c5d61..63fd62d 100644 --- a/config/webpack/loader/arrange-shared-module-loader.js +++ b/config/webpack/loader/arrange-shared-module-loader.js @@ -27,7 +27,11 @@ export default function(source) { if (moduleIndex >= 0) { const currentSharedModuleName = sharedModules[moduleIndex]; - if (!(sortedSharedModules.includes(currentSharedModuleName) || modulesToBeIncluded.includes(currentSharedModuleName))) { + const alreadyIncluded = ( + sortedSharedModules.includes(currentSharedModuleName) + || modulesToBeIncluded.includes(currentSharedModuleName)); + + if (!alreadyIncluded) { modulesToBeIncluded.push(currentSharedModuleName); } } diff --git a/config/webpack/plugins/create-injected-shared-modules-webpack-plugin.js b/config/webpack/plugins/create-injected-shared-modules-webpack-plugin.js index 6cd8523..c94ae86 100644 --- a/config/webpack/plugins/create-injected-shared-modules-webpack-plugin.js +++ b/config/webpack/plugins/create-injected-shared-modules-webpack-plugin.js @@ -21,6 +21,7 @@ class CreateInjectedSharedModulesPlugin { /** * @param {import("webpack").Compiler} compiler + * @returns {void} */ apply(compiler) { compiler.hooks.compilation.tap("CreateInjectedSharedModulesPlugin", (compilation) => { diff --git a/config/webpack/plugins/create-manifest-webpack-plugin/index.js b/config/webpack/plugins/create-manifest-webpack-plugin/index.js index f5a4963..95d0be8 100644 --- a/config/webpack/plugins/create-manifest-webpack-plugin/index.js +++ b/config/webpack/plugins/create-manifest-webpack-plugin/index.js @@ -38,6 +38,7 @@ class CreateManifestPlugin { /** * @param {import("webpack").Compiler} compiler + * @returns {void} */ apply(compiler) { compiler.hooks.compilation.tap("CreateManifestPlugin", (compilation) => { diff --git a/config/webpack/plugins/create-rules-webpack-plugin.js b/config/webpack/plugins/create-rules-webpack-plugin.js index 10e5fdd..ce2fbef 100644 --- a/config/webpack/plugins/create-rules-webpack-plugin.js +++ b/config/webpack/plugins/create-rules-webpack-plugin.js @@ -11,6 +11,7 @@ import webpack from "webpack"; class CreateRulesPlugin { /** * @param {import("webpack").Compiler} compiler + * @returns {void} */ apply(compiler) { compiler.hooks.compilation.tap("CreateRulesPlugin", (compilation) => { diff --git a/config/webpack/plugins/inject-script-webpack-plugin.js b/config/webpack/plugins/inject-script-webpack-plugin.js index 0a5d784..16b2e98 100644 --- a/config/webpack/plugins/inject-script-webpack-plugin.js +++ b/config/webpack/plugins/inject-script-webpack-plugin.js @@ -14,6 +14,7 @@ import { getInjectedCode } from "../utils/injected-code.js"; class InjectScriptPlugin { /** * @param {import("webpack").Compiler} compiler + * @returns {void} */ apply(compiler) { compiler.hooks.compilation.tap("InjectScriptPlugin", (compilation) => { @@ -26,14 +27,16 @@ class InjectScriptPlugin { async(assets) => { for (const assetName in assets) { if (/\.js$/.test(assetName)) { - const injectedCodeResponse = getInjectedCode(compilation.getAsset(assetName).source.source()); + const assetSource = compilation.getAsset(assetName).source.source(); + const injectedCodeResponse = getInjectedCode(assetSource); const scriptInjectorModuleName = getFileName("script-injector", "shared", true); compilation.updateAsset( assetName, new webpack.sources.RawSource(injectedCodeResponse[0]) ); + const injectedFileName = `scripts/injected/${path.basename(assetName)}`; assets["scripts/" + path.basename(assetName)] = new webpack.sources.RawSource( - `$${scriptInjectorModuleName}.injectScriptHead("scripts/injected/${path.basename(assetName)}", ${injectedCodeResponse[1]});` + `$${scriptInjectorModuleName}.injectScriptHead("${injectedFileName}", ${injectedCodeResponse[1]});` ); } } -- cgit v1.2.3