From d178caee5c93ad9ed91dbd082b0f0b5a9b0507aa Mon Sep 17 00:00:00 2001 From: Arpit Chakladar <54011232+arpitchakladar@users.noreply.github.com> Date: Mon, 27 Mar 2023 21:38:43 +0530 Subject: Refactoring code. Only using hashes for output file names. Using singleton pattern to store the callbacks for observeDOM, and only one MutationObserver. --- config/webpack/loader/dynamic-imports-loader.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'config/webpack/loader/dynamic-imports-loader.js') diff --git a/config/webpack/loader/dynamic-imports-loader.js b/config/webpack/loader/dynamic-imports-loader.js index 06f9704..12eb5b7 100644 --- a/config/webpack/loader/dynamic-imports-loader.js +++ b/config/webpack/loader/dynamic-imports-loader.js @@ -5,18 +5,18 @@ const sharedModules = webpackRequire("utils/shared-modules.js"); module.exports = source => { const manager = new ImportManager(source); - let modified = false; for (const unit of manager.imports.es6.units) { const moduleIndex = sharedModules.indexOf(unit.module.name); + if (moduleIndex >= 0 && unit.type === "es6") { const importedModuleNames = unit.members.entities .map(entity => `\t${entity.name}`) .concat(unit.defaultMembers.entities.map(entity => `\tdefault: ${entity.name}`)) .join(",\n"); - const importStatement = `const {\n${importedModuleNames}\n} = await import(/* webpackIgnore: true */ "/shared/${getFileNameHash(sharedModules[moduleIndex])}.js");\n`; + const importStatement = `const {\n${importedModuleNames}\n} = await import(/* webpackIgnore: true */ "/shared/${getFileNameHash(sharedModules[moduleIndex], "shared")}.js");\n`; unit.methods = { makeUntraceable() {} -- cgit v1.2.3